Add tab completion, path modifications #746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcd1193182
force-pushed
the
dlpx/pr/pcd1193182/9f98958e-bbbd-4dba-9525-21419cd8065e
branch
from
29d0bfb to
ad20567
Compare
pcd1193182
requested review from
prakashsurya,
mwatson-delphix and
palash-gandhi
|
Shouldn't we put this in delphix-platform, so it works for existing engines after an upgrade? This will just do it for new installs.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Interacting with the systemctl command line tools can be cumbersome. Finding what services exist
and are active can require grepping the output of commands that are not intended for machine parsing.
Remembering and entering the full names of commands is potentially cumbersome if you don't use them
regularly. There are tab completion scripts that intend to solve these problems.
We also have similar problems with the zfs command line tools and the /opt/delphix/server/bin path.
These things add small friction to countless processes that can be easily reduced.
Solution
We add tab completion scripts to the standard location for them on ubuntu systems, and then
source those scripts to get their functionality. We also add the /opt/delphix path to the
delphix user's PATH variable.
Testing Done
Spun up a development VM with these changes and verified that they all performed as expected.