Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

add checks for mysql version, change alter user syntax if it's 8 or g… #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DCSTOLF
Copy link

@DCSTOLF DCSTOLF commented Jan 12, 2023

add checks for mysql version, changes alter user syntax in case it's 8 or greater. fixes mysql parameter regex in schema.json.

Background

the current version of the plugin will break with mysql 8 or mariadb.

it also doesn't accept valid mysql parameter names and values.

Problem

  • The alter user command used when creating a staging database or vdb is different on MySQL 8.
  • Repository discovery breaks trying to parse mysqld --version and it's MariaDB
  • The regex that validates mysql parameters is wrong for any mysql version.

Solution

  • The MySQL version needs to be checked so the alter user command is built properly and the plugin doesn't break completely if it's version 8.

  • The repository parsing needs to check for MySQL or MariaDB so it won't break if it's MariaDB.

  • Fixing regex so it accepts dashes on property name and dashes or periods in property value.

Testing Done

Tested on my lab and at a customer who's trying delphix on mysql.

Notes to Reviewers

Customer is not entitled to select connector, but these are easy fixes that will benefit any customer.

…reater. fix custom parameters regex pattern in schema.json
@vinaybyrappa
Copy link
Collaborator

Closing this PR to fix secret scanning issue using BFG. Will reopen once done

@vinaybyrappa
Copy link
Collaborator

Reopening the PR as BFG tool activity is done

@vinaybyrappa vinaybyrappa reopened this Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants