-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kelp: gain : tvl for blancer, pendle, spectra users #294
Conversation
1b095d7
to
a38c578
Compare
b26c62c
to
4320481
Compare
if (totalRsEthSaveToCSV > rsEthTotalSupply) { | ||
throw new Error( | ||
`The total balance in CSV ${totalRsEthSaveToCSV} can not more than total supply ${rsEthTotalSupply}` | ||
); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently this is just checking if sum of rseth in csv is more than total supply. but my concern here is that one of the function might return 0 result when it is not suppose to, which we ended up ingesting that.
can we modify this check to make sure those function that is suppose to return data in the specific block is doing so, and throw error if it isnt?
Title:
Checklist before requesting a review
index.ts file
Contains function
getUserTVLByBlock function takes input with this schema
getUserTVLByBlock function returns output in this schema
contains function
has this code
Your code is handling Pagination to make sure all data for a given block is returned
Output data