[Chore] Use helpers to simplify expression handling code #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
commented
Oct 15, 2024
| @@ -134,6 +134,13 @@ pub enum Expression { | |||
| Column(String), | |||
| /// A struct computed from a Vec of expressions | |||
| Struct(Vec<Expression>), | |||
| /// A unary operation. | |||
| UnaryOperation { | |||
There was a problem hiding this comment.
Seems more logical to order these unary -> binary -> variadic.
| @@ -609,23 +590,23 @@ mod tests { | |||
| let batch = RecordBatch::try_new(Arc::new(schema.clone()), vec![Arc::new(values)]).unwrap(); | |||
| let column = Expression::column("a"); | |||
|
|
|||
| let expression = Box::new(column.clone().add(Expression::Literal(Scalar::Integer(1)))); | |||
There was a problem hiding this comment.
Not sure why these tests were boxing everything... but it's not needed now.
scovich
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
- Coverage 78.34% 78.28% -0.07%
==========================================
Files 50 50
Lines 10341 10292 -49
Branches 10341 10292 -49
==========================================
- Hits 8102 8057 -45
+ Misses 1785 1781 -4
Partials 454 454 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
breaking-change
zachschuermann
approved these changes
Oct 18, 2024
| @@ -234,7 +234,7 @@ impl Expression { | |||
| } | |||
|
|
|||
| /// Create a new struct expression | |||
| pub fn struct_expr(exprs: impl IntoIterator<Item = Self>) -> Self { | |||
| pub fn struct_from(exprs: impl IntoIterator<Item = Self>) -> Self { | |||
There was a problem hiding this comment.
flagging breaking change
There was a problem hiding this comment.
Don't worry, semver check caught it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel provides quite a few helper methods that make it easier to create expressions, but not all call sites take advantage of them. Fix that.
Also update the various binary operation helpers to accept
impl Into<Expression>as their RHS arg, which allows further simplifications.