-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] replace panic with .to_compiler_error in macros #409
Conversation
Signed-off-by: Niko <[email protected]>
awesome, thanks @r3stl355! I've just updated the PR description a little bit to make it clearer and tagged some people for review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 78.85% 78.80% -0.06%
==========================================
Files 51 51
Lines 10640 10647 +7
Branches 10640 10647 +7
==========================================
Hits 8390 8390
- Misses 1781 1788 +7
Partials 469 469 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much nicer thanks! Just a small thing about the formatting.
Co-authored-by: Nick Lanham <[email protected]>
Co-authored-by: Nick Lanham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Replace
panic!
withto_compiler_error
in macros.There seem to be no tests for macros, maybe worth adding but probably deserves a separate issue
resolves #348