Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] replace panic with .to_compiler_error in macros #409

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

r3stl355
Copy link
Contributor

@r3stl355 r3stl355 commented Oct 18, 2024

Replace panic! with to_compiler_error in macros.

There seem to be no tests for macros, maybe worth adding but probably deserves a separate issue

resolves #348

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Oct 18, 2024
@zachschuermann zachschuermann requested review from nicklan, zachschuermann, scovich and hntd187 and removed request for nicklan, zachschuermann and scovich October 18, 2024 16:49
@zachschuermann
Copy link
Collaborator

awesome, thanks @r3stl355! I've just updated the PR description a little bit to make it clearer and tagged some people for review

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.80%. Comparing base (6e8bd3e) to head (78b5aeb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
derive-macros/src/lib.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   78.85%   78.80%   -0.06%     
==========================================
  Files          51       51              
  Lines       10640    10647       +7     
  Branches    10640    10647       +7     
==========================================
  Hits         8390     8390              
- Misses       1781     1788       +7     
  Partials      469      469              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nicklan nicklan requested a review from azdavis October 21, 2024 23:03
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer thanks! Just a small thing about the formatting.

derive-macros/src/lib.rs Outdated Show resolved Hide resolved
derive-macros/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nicklan nicklan merged commit 8de8689 into delta-io:main Oct 22, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use to_compile_error or into_compile_error for errors in our proc macro, rather than panicing
4 participants