Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.4.0! #416

Merged
merged 5 commits into from
Oct 23, 2024
Merged

release 0.4.0! #416

merged 5 commits into from
Oct 23, 2024

Conversation

zachschuermann
Copy link
Collaborator

@zachschuermann zachschuermann commented Oct 22, 2024

Release 0.4.0 of all crates! rendered changelog link

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (7385d19) to head (9ef83c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage   78.82%   78.82%           
=======================================
  Files          51       51           
  Lines       10655    10655           
  Branches    10655    10655           
=======================================
  Hits         8399     8399           
  Misses       1788     1788           
  Partials      468      468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, and very thorough, tho I don't know how to be sure it's complete?

For the breaking change list, it seems helpful to add a sentence to each item explaining what kind of breakage the change might cause for existing code?

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks, just a few things

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@zachschuermann
Copy link
Collaborator Author

Generally looks good, and very thorough, tho I don't know how to be sure it's complete?

Thanks! And yea, this is generally done as best-effort by me going through every PR that merged since the last release..

For the breaking change list, it seems helpful to add a sentence to each item explaining what kind of breakage the change might cause for existing code?

Yea good idea, I can try to add more to breaking changes to help migrations.

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@@ -183,4 +183,4 @@ Some design principles which should be considered:
[cargo-llvm-cov]: https://github.com/taiki-e/cargo-llvm-cov
[FFI]: ffi/
[Arrow]: https://arrow.apache.org/rust/arrow/index.html
[Tokio]: https://tokio.rs/
[Tokio]: https://tokio.rs/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, what changed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the newline? idk maybe some editor junk?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file didn't have a newline at EOF before, and now it does?

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks great

CHANGELOG.md Outdated
3. new `WriterFeatures` enum variant: `TypeWidening` and `TypeWideningPreview` [\#335]
4. new `Error` enum variant: `InvalidLogPath` when kernel is unable to parse the name of a log path [\#347]
5. Module moved: `mod delta_kernel::transaction` -> `mod delta_kernel::actions::set_transaction` [\#386]
6. output of arrow expression evaluation now applies/validates output schema in default arrow expression handler [\#331]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one really a breaking change? Seems like it would just allow previously broken stuff to no longer break?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yea I had the same question (where we should put those changes to expression evaluation). I agree it "allows previously broken stuff to no longer break" and since the semantics remain the same (just that we are enforcing/implementing it now) perhaps this goes under 'fixes'? WDYT @nicklan @scovich

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fixes is probably good. I don't know how critical it is that we get the changelog "just right" at this point, but nothing will break due to this change (i don't think) so fixes or enhancements makes sense.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! releasing!

@zachschuermann zachschuermann merged commit b09078d into delta-io:main Oct 23, 2024
17 checks passed
@zachschuermann zachschuermann deleted the prepare-0.4.0 branch October 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants