-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] add derive macro tests #514
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Niko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
=======================================
Coverage 80.31% 80.31%
=======================================
Files 62 62
Lines 13541 13541
Branches 13541 13541
=======================================
Hits 10876 10876
Misses 2106 2106
Partials 559 559 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few questions!
…with both single and multi-part paths Signed-off-by: Niko <[email protected]>
I added a second part that fixes an error in macro when fully-qulified multi-part types are used (forgot to push this earlier). Also added a passing docs test to verify, this test needs to be moved to normal test as part of #526 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What changes are proposed in this pull request?
A simplified version of PR429 (to be closed/abandoned) using a doctest trick.
crate::
todelta_kernel::
in the generated code.developer-visibility
feature instead of adding a new one as it seemed to fit the purposejustfile
to run the new tests as part of existing testing processHow was this change tested?
All tests pass, including the newly added