-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffi][prefactor] add kernel_utils
header in read_table example
#539
[ffi][prefactor] add kernel_utils
header in read_table example
#539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 65 65
Lines 14099 14099
Branches 14099 14099
=======================================
Hits 11425 11425
Misses 2093 2093
Partials 581 581 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a request to move the VERBOSE define into cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
moved out some pieces of
read_table.c
and put intokernel_utils.h/c
. just some small README updates otherwise.