Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffi][prefactor] add kernel_utils header in read_table example #539

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

zachschuermann
Copy link
Collaborator

moved out some pieces of read_table.c and put into kernel_utils.h/c. just some small README updates otherwise.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (f1f8a82) to head (6aea7ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          65       65           
  Lines       14099    14099           
  Branches    14099    14099           
=======================================
  Hits        11425    11425           
  Misses       2093     2093           
  Partials      581      581           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a request to move the VERBOSE define into cmake

ffi/examples/read-table/kernel_utils.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@zachschuermann zachschuermann merged commit 7bfd119 into delta-io:main Nov 25, 2024
20 checks passed
@zachschuermann zachschuermann deleted the kernel-utils-header branch November 25, 2024 23:14
@zachschuermann zachschuermann removed the breaking-change Change that will require a version bump label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants