Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CHANGELOG with current unreleased changes #544

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

zachschuermann
Copy link
Collaborator

added current unreleased changes before 0.5.0 release (separate PR with hopefully a bit of automation)

view rendered

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (6eb2dc4) to head (5946a4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   80.73%   80.74%           
=======================================
  Files          67       67           
  Lines       14076    14076           
  Branches    14076    14076           
=======================================
+ Hits        11364    11365    +1     
+ Misses       2138     2136    -2     
- Partials      574      575    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

13. New `TableProperties` struct which can parse tables' `metadata.configuration` [\#453] [\#536]

**Implemented enhancements:**
- FFI examples now use AddressSanitizer [\#447]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: How come we use - for these bullet points, but numbers in the Additions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason lol other than it felt nice to have structure in the changes/additions and felt less useful here. want numbers everwhere?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference towards a consistent bullets, but I'm cool with either.

@OussamaSaoudi-db
Copy link
Collaborator

Besides addressing the TODO on line 14 of Breaking changes, it LGTM.

@OussamaSaoudi-db OussamaSaoudi-db self-requested a review November 27, 2024 00:06
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except two additions masquerading as breaking changes.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! wow that's a lot of changes

@zachschuermann zachschuermann merged commit 2c91040 into delta-io:main Nov 27, 2024
20 checks passed
@zachschuermann zachschuermann deleted the changelog-0.5.0 branch November 27, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants