-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CHANGELOG with current unreleased changes #544
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
=======================================
Coverage 80.73% 80.74%
=======================================
Files 67 67
Lines 14076 14076
Branches 14076 14076
=======================================
+ Hits 11364 11365 +1
+ Misses 2138 2136 -2
- Partials 574 575 +1 ☔ View full report in Codecov by Sentry. |
13. New `TableProperties` struct which can parse tables' `metadata.configuration` [\#453] [\#536] | ||
|
||
**Implemented enhancements:** | ||
- FFI examples now use AddressSanitizer [\#447] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: How come we use -
for these bullet points, but numbers in the Additions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason lol other than it felt nice to have structure in the changes/additions and felt less useful here. want numbers everwhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight preference towards a consistent bullets, but I'm cool with either.
Besides addressing the TODO on line 14 of Breaking changes, it LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except two additions masquerading as breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! wow that's a lot of changes
added current unreleased changes before
0.5.0
release (separate PR with hopefully a bit of automation)view rendered