[wip] add in-commit timestamps table properties #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
|
Mention: #559 |
scovich
reviewed
Dec 5, 2024
| props.enable_in_commit_timestamps = Some(parse_bool(v)?) | ||
| } | ||
| "delta.inCommitTimestampEnablementVersion" => { | ||
| props.in_commit_timestamp_enablement_version = Some(parse_int(v)?) |
There was a problem hiding this comment.
Something went wrong:
error[E0425]: cannot find function `parse_int` in this scope
--> /Users/runner/work/delta-kernel-rs/delta-kernel-rs/kernel/src/table_properties/deserialize.rs:83:65
|
83 | props.in_commit_timestamp_enablement_version = Some(parse_int(v)?)
| ^^^^^^^^^ not found in this scope
error[E0425]: cannot find function `parse_int` in this scope
--> /Users/runner/work/delta-kernel-rs/delta-kernel-rs/kernel/src/table_properties/deserialize.rs:86:67
|
86 | props.in_commit_timestamp_enablement_timestamp = Some(parse_int(v)?)
| ^^^^^^^^^ not found in this scope
(I think all the other int properties use parse_positive_int and parse_int may not even exist?)
(these two do need to tolerate 0)
There was a problem hiding this comment.
yea sorry opened this as a sort of "todo" and will fix this :)
There was a problem hiding this comment.
sorry should have probably made it a draft...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this change tested?