-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump msrv and ensure tests work with msrv #590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a question but LGTM
- name: Install minimal stable and cargo msrv | ||
uses: actions-rs/toolchain@v1 | ||
with: | ||
profile: default | ||
toolchain: stable | ||
override: true | ||
- uses: Swatinem/rust-cache@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @roeap will need to make his changes over here too :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 83.46% 83.44% -0.03%
==========================================
Files 74 74
Lines 16858 16858
Branches 16858 16858
==========================================
- Hits 14071 14067 -4
- Misses 2129 2131 +2
- Partials 658 660 +2 ☔ View full report in Codecov by Sentry. |
also heads up looks like new job failed to get the version for toolchain:
|
Yeah. I'll request when it's ready. I expect to fight with actions a bit before I get this working |
haha sounds good - sorry i jumped the gun a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restamp
closing in favor of #596 |
What changes are proposed in this pull request?
cargo msrv
doesn't seem to be able to check tests, so we add a new workflow to make surecargo test
at least works with ourrust-version
.Incidentally, we need to bump to 1.81.0 for a test.
How was this change tested?