-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table changes example, improve TableChanges
documentation
#597
Add table changes example, improve TableChanges
documentation
#597
Conversation
TableChanges
documentationTableChanges
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
=======================================
Coverage 83.48% 83.49%
=======================================
Files 74 74
Lines 16884 16889 +5
Branches 16884 16889 +5
=======================================
+ Hits 14096 14101 +5
+ Misses 2131 2129 -2
- Partials 657 659 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just nits
removing |
c7f05de
to
0e49c9b
Compare
…lta-kernel-rs into cdf_test_and_example
What changes are proposed in this pull request?
This PR adds an example for using and reading table changes for a table through a CLI.
We also introduce a cdf test on a table that was generated with various merge operations. This table contains both deletion vectors and cdc actions.
This PR also improves the documentation for the
table_changes
module so that example usage is clear in the user docs.How was this change tested?
Cargo doc and cargo test both run successfully