Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table changes example, improve TableChanges documentation #597

Merged
merged 9 commits into from
Dec 14, 2024

Conversation

OussamaSaoudi-db
Copy link
Collaborator

@OussamaSaoudi-db OussamaSaoudi-db commented Dec 13, 2024

What changes are proposed in this pull request?

This PR adds an example for using and reading table changes for a table through a CLI.

We also introduce a cdf test on a table that was generated with various merge operations. This table contains both deletion vectors and cdc actions.

This PR also improves the documentation for the table_changes module so that example usage is clear in the user docs.

How was this change tested?

Cargo doc and cargo test both run successfully

@OussamaSaoudi-db OussamaSaoudi-db changed the title Add cdc test and improve TableChanges documentation Add table changes example, improve TableChanges documentation Dec 13, 2024
@github-actions github-actions bot added the breaking-change Change that will require a version bump label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (702e12f) to head (31fb911).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   83.48%   83.49%           
=======================================
  Files          74       74           
  Lines       16884    16889    +5     
  Branches    16884    16889    +5     
=======================================
+ Hits        14096    14101    +5     
+ Misses       2131     2129    -2     
- Partials      657      659    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kernel/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just nits

kernel/examples/read-table-changes/src/main.rs Outdated Show resolved Hide resolved
kernel/src/table_changes/mod.rs Outdated Show resolved Hide resolved
kernel/src/table_changes/mod.rs Outdated Show resolved Hide resolved
kernel/src/table_changes/mod.rs Outdated Show resolved Hide resolved
@zachschuermann zachschuermann removed the breaking-change Change that will require a version bump label Dec 13, 2024
@zachschuermann
Copy link
Collaborator

removing breaking-change label - was failing on something in test_utils? but no breaking changes here

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Dec 13, 2024
@OussamaSaoudi-db OussamaSaoudi-db removed the breaking-change Change that will require a version bump label Dec 14, 2024
kernel/src/table_changes/mod.rs Outdated Show resolved Hide resolved
@OussamaSaoudi-db OussamaSaoudi-db merged commit c33ae00 into delta-io:main Dec 14, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants