Disable default-features of reqwest #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reqwest is part of default-engine, so is included by default by engines. This enables reqwest with default features, which will include a dependency on openssl. Having a dependency on openssl requires some system libraries to be present in the runtime environment, so it's better to have it be optional.
|
hi @jkylling thanks for opening this! I think we had a very similar issue and to resolve it I've got a PR up to remove default-features and let us pull in with that PR instead of using |
|
Thank you! I'll close this one in favour of #572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Reqwest is part of default-engine, so is included by default by engines. This enables reqwest with default features, which will include a dependency on openssl. Having a dependency on openssl requires some system libraries to be present in the runtime environment, so it's better to have it be optional.
How was this change tested?