[chore] add CI step to build kernel with no-default-features #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 74 74
Lines 16877 16877
Branches 16877 16877
=======================================
+ Hits 14084 14085 +1
+ Misses 2135 2133 -2
- Partials 658 659 +1 ☔ View full report in Codecov by Sentry. |
nicklan
approved these changes
Dec 16, 2024
you got it! #603 |
OussamaSaoudi-db
approved these changes
Dec 17, 2024
zachschuermann
added a commit
that referenced
this pull request
Dec 17, 2024
Our builds are actually broken due to a dependency on `mod engine` in `scan/mod.rs` (which only exists when one of the engine feature-flags is enabled. as soon as all are off, it fails to build). This fixes the issue by moving the `parquet_stats_skipping` module out of engine code and into `expressions` module. This was trivial since it actually doesn't depend on any engine code. We pull `parquet_stats_skipping` into `scan/mod.rs` in order to `impl ParquetStatsProvider for NoStats`. Now instead of having this rely on engine code, it's moved to the `predicates` module (which is always included) Note that I have a new test in CI that will catch this failure in the future: #601
OussamaSaoudi-db
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title. Introducing since this would have caught the 0.6.0 release blocker. (
enginecode used inparquet_stats_skippingmodule)