-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix msrv check by pinning home
dependency
#605
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 74 74
Lines 16877 16877
Branches 16877 16877
=======================================
Hits 14084 14084
Misses 2135 2135
Partials 658 658 ☔ View full report in Codecov by Sentry. |
Seems like we'd need to manually update this if we want to stay up to date with hdfs/home. Is this a problem if we forget or leave it at this version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! also is there a way to get better output in the CI job? failing was just showing 'exited with code 1'
Yeah, if hdfs-native updates and needs a newer version of home we'll either have to pin an older version of that crate or bump our msrv. We can deal with that as needed. |
Yeah, there are some options. I didn't enable them here since I think in general checking locally should repo things as long as we remember to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needed to do the exact same change in delta-rs ...
Lol yea the 'remember to |
Ahh so it will fail compilation and tell us we need to update home. That's good. thx! |
What changes are proposed in this pull request?
hdfs-native
depends onwhich
which depends onhome
.home
recently updated and bumped their msrv to 1.81. This pins us to the previous version.How was this change tested?
Check that the msrv test now passes