Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 4: read_table.c uses transform in ffi #614

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

nicklan
Copy link
Collaborator

@nicklan nicklan commented Dec 20, 2024

Stacked PR. Only review these commits

What changes are proposed in this pull request?

Use new transform functionality to transform data over FFI.

This lets us get rid of all the gross partition adding code in c :)

Still some things to work out here wrt. ffi types, so this is very much a draft.

But it works.

How was this change tested?

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 70.80537% with 87 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (c3a868f) to head (b961220).

Files with missing lines Patch % Lines
ffi/src/scan.rs 0.00% 33 Missing ⚠️
ffi/src/engine_funcs.rs 66.17% 23 Missing ⚠️
kernel/src/scan/log_replay.rs 86.53% 7 Missing and 7 partials ⚠️
ffi/src/expressions/kernel.rs 0.00% 13 Missing ⚠️
kernel/src/scan/mod.rs 95.58% 0 Missing and 3 partials ⚠️
kernel/src/engine/arrow_expression.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   83.45%   83.24%   -0.21%     
==========================================
  Files          74       74              
  Lines       16877    17080     +203     
  Branches    16877    17080     +203     
==========================================
+ Hits        14084    14218     +134     
- Misses       2135     2201      +66     
- Partials      658      661       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the breaking-change Change that will require a version bump label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change that will require a version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant