Skip to content

Commit

Permalink
comment out mode for now
Browse files Browse the repository at this point in the history
  • Loading branch information
ion-elgreco committed Nov 19, 2023
1 parent 84bec47 commit 02db6e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion python/deltalake/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
from .schema import Schema as Schema
from .table import DeltaTable as DeltaTable
from .table import Metadata as Metadata
from .writer import write_deltalake as write_deltalake
from .writer import convert_to_deltalake as convert_to_deltalake
from .writer import write_deltalake as write_deltalake
9 changes: 4 additions & 5 deletions python/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1193,7 +1193,7 @@ fn write_new_deltalake(
#[allow(clippy::too_many_arguments)]
fn convert_to_deltalake(
uri: String,
mode: &str,
// mode: &str,
_partition_schema: Option<Vec<String>>,
partition_strategy: Option<String>,
name: Option<String>,
Expand All @@ -1202,10 +1202,9 @@ fn convert_to_deltalake(
storage_options: Option<HashMap<String, String>>,
custom_metadata: Option<HashMap<String, String>>,
) -> PyResult<()> {
let mode = save_mode_from_str(mode)?;
let mut builder = ConvertToDeltaBuilder::new()
.with_location(uri)
.with_save_mode(mode);
// let mode = save_mode_from_str(mode)?;
let mut builder = ConvertToDeltaBuilder::new().with_location(uri);
// .with_save_mode(mode);

// if let Some(part_schema) = partition_schema {
// builder = builder.with_partition_schema(part_schema); // Convert type properly in struct field
Expand Down

0 comments on commit 02db6e7

Please sign in to comment.