Skip to content

Commit

Permalink
remove comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ion-elgreco committed Nov 16, 2023
1 parent 69dd9d9 commit 2932609
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions python/deltalake/writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,8 @@ def write_deltalake(
table.update_incremental()

if engine == "rust":
# Easier to do this check in Python than rust
if table is not None and mode == "ignore":
return
### COMMENTS ###
# - Don't check partition columns if they are the same, this is done on the rust side implicility
# - Consolidate the recordbatch reader part with the new update
# - Add overwrite schema functionality in rust writer
# - Figure out how to add name, description and configuration to the correct metadata in transaction

if isinstance(data, RecordBatchReader):
batch_iter = data
Expand Down

0 comments on commit 2932609

Please sign in to comment.