fix: upgrade python ABI to 3.9 from 3.8

The release of pyo3 0.22.3 compells this since we cannot otherwise compile. The choice is between pinning 0.22.2 and upgrading our ABI, and I think it's better to upgrade the ABI
delta-io · Sep 20, 2024 · b325e27 · b325e27
1 parent 5fcfac5
commit b325e27
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/crates/core/src/delta_datafusion/mod.rs b/crates/core/src/delta_datafusion/mod.rs
@@ -77,9 +77,7 @@ use url::Url;
 use crate::delta_datafusion::expr::parse_predicate_expression;
 use crate::delta_datafusion::schema_adapter::DeltaSchemaAdapterFactory;
 use crate::errors::{DeltaResult, DeltaTableError};
-use crate::kernel::{
-    Add, DataCheck, EagerSnapshot, Invariant, Snapshot, StructTypeExt,
-};
+use crate::kernel::{Add, DataCheck, EagerSnapshot, Invariant, Snapshot, StructTypeExt};
 use crate::logstore::LogStoreRef;
 use crate::table::builder::ensure_table_uri;
 use crate::table::state::DeltaTableState;

diff --git a/python/Cargo.toml b/python/Cargo.toml
@@ -44,7 +44,7 @@ deltalake-mount = { path = "../crates/mount" }
 
 [dependencies.pyo3]
 version = "0.22.2"
-features = ["extension-module", "abi3", "abi3-py38"]
+features = ["extension-module", "abi3", "abi3-py39"]
 
 [dependencies.deltalake]
 path = "../crates/deltalake"

diff --git a/python/src/lib.rs b/python/src/lib.rs
@@ -1418,6 +1418,7 @@ fn scalar_to_py<'py>(value: &Scalar, py_date: &Bound<'py, PyAny>) -> PyResult<Bo
             }
             py_struct.to_object(py)
         }
+        Array(val) => todo!("how should this be converted!"),
     };
 
     Ok(val.into_bound(py))
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 py_struct.to_object(py)
             }
+            Array(val) => todo!("how should this be converted!"),
         };
         Ok(val.into_bound(py))
@@ Expand Down @@