-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade datafusion 33 #1775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
Issues for the Python package
binding/rust
Issues for the Rust crate
rust
labels
Oct 26, 2023
Requires a fix for the following regression apache/arrow-rs#5038 This was found by the checkpoint writer tests |
github-actions
bot
added
binding/rust
Issues for the Rust crate
crate/core
crate/sql
labels
Nov 14, 2023
Blajda
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
November 17, 2023 02:40
wjones127
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
binding/python
Issues for the Python package
binding/rust
Issues for the Rust crate
crate/core
crate/sql
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've had to live on the bleeding edge of datafusion since I've discovered multiple bugs while implementing merge enhancements. Creating this PR to contain changes necessary to use it.
Datafusion has made significant changes with how table statistics are represented. I refactored and was able to trim a significant amount of code.
There were some bugs with how we presented statistics for tables that do not contain column metadata (deleta-0.2.0) where we stated the number of records for a file is 0.
Fixes
The null-ability status for partition columns are now accurately captured by Datafusion. Before if a partition column contained a null value an error would be returned. This should be resolved now.