Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade datafusion 33 #1775

Merged
merged 15 commits into from
Nov 17, 2023
Merged

chore: upgrade datafusion 33 #1775

merged 15 commits into from
Nov 17, 2023

Conversation

Blajda
Copy link
Collaborator

@Blajda Blajda commented Oct 26, 2023

Description

I've had to live on the bleeding edge of datafusion since I've discovered multiple bugs while implementing merge enhancements. Creating this PR to contain changes necessary to use it.

Datafusion has made significant changes with how table statistics are represented. I refactored and was able to trim a significant amount of code.
There were some bugs with how we presented statistics for tables that do not contain column metadata (deleta-0.2.0) where we stated the number of records for a file is 0.

Fixes

The null-ability status for partition columns are now accurately captured by Datafusion. Before if a partition column contained a null value an error would be returned. This should be resolved now.

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate rust labels Oct 26, 2023
@Blajda
Copy link
Collaborator Author

Blajda commented Nov 5, 2023

Requires a fix for the following regression apache/arrow-rs#5038 This was found by the checkpoint writer tests

@github-actions github-actions bot removed rust binding/rust Issues for the Rust crate labels Nov 5, 2023
@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core crate/sql labels Nov 14, 2023
@Blajda Blajda marked this pull request as ready for review November 17, 2023 02:40
@Blajda Blajda requested a review from rtyler as a code owner November 17, 2023 02:40
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@wjones127 wjones127 merged commit 4d103a7 into delta-io:main Nov 17, 2023
24 checks passed
@Blajda Blajda deleted the datafusion-head branch November 17, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate crate/core crate/sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants