-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kernel ExpressionEvaluator #1829
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
fab4a26
to
b49170b
Compare
Once this is merged in do you suggest we remove the CNF expressions we use for optimize? Seem like we should depreciate that interface and also create a bridge between string expressions and maybe extra code to convert to an equivalent Datafusion expression. |
From the kernel side, the general idea is to have a way of defining expressions without additional dependencies. So yes, we should ten likely define conversions to datafusion expressions. I only looked a bit into our partition filters, if we could remove those too... From the python API side at least we probably want to keep CNF expressions around? |
348450c
to
09b55b0
Compare
based on #1807Description
In the effort to advance protocol support and move our internal APIs closer to the kernel library, it is advantageous to leverage the expression handling logic from kernel specifically for filtering actions etc.
This PR just add the expression definitions and evaluation logic. Integrating it with our current codebase and basing the existing partition handling logic on this is left for follow up PRs to keep thigs review-able.
related: #1894, #1776