Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run integration tests in CI #1830

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Nov 9, 2023

Description

For our integrations tests we we selecting the deltalake crate. After splitting the crate into smaller crates, integration tests are no longer defined there, and thus are currently not executed in CI.

rtyler
rtyler previously approved these changes Nov 9, 2023
@rtyler rtyler enabled auto-merge (rebase) November 9, 2023 16:37
@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Nov 9, 2023
@roeap
Copy link
Collaborator Author

roeap commented Nov 9, 2023

@rtyler @wjones127 - it seems the s3 specific repair_when_worker_pauses_{after,before}_rename_tests are hanging indefinately right now. I disabled them for the currently passing test. Could this be related to the recent dynamo-db lock update? WHich bear the question should we maintain tests tests here, or does it make more sense to move them to the lock crate repo?

@rtyler rtyler merged commit 6ac9698 into delta-io:main Nov 9, 2023
21 checks passed
@roeap roeap deleted the fix-integration branch May 26, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate crate/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants