-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): expose rust writer as additional engine v2 #1891
Merged
ion-elgreco
merged 38 commits into
delta-io:main
from
ion-elgreco:fix/expose_writer_rust_to_python_v2
Nov 29, 2023
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ca2acb8
first version
ion-elgreco 3f55470
add try from uri with storage options
ion-elgreco 714cc56
Start to enable overwrite_schema
ion-elgreco 52f0d6a
add tests to check rust py03 writer
ion-elgreco c067d4d
remove comment
ion-elgreco 5c5f247
rename and clean up
ion-elgreco 717b7c7
add float type support in partition cols
ion-elgreco dae361e
check for pandas
ion-elgreco 3052f12
add support for name and desc
ion-elgreco 01f0194
fmt
ion-elgreco 9911574
improve tests and add config support
ion-elgreco a410dfa
parametrize write benchmark
ion-elgreco 8c976b6
add LargeUtf8 support in partition stringify
ion-elgreco 57565b5
refactor: express log schema in delta types
roeap 49a298b
feat(python): expose `convert_to_deltalake` (#1842)
ion-elgreco 635313f
refactor: merge to use logical plans (#1720)
Blajda 633fd7f
feat: create benchmarks for merge (#1857)
Blajda 07113c6
Revert "refactor: express log schema in delta types"
ion-elgreco 3a8c026
Merge branch 'main' into feat/expose_rust_writer_as_optional_engine
ion-elgreco 3e25561
formatting
ion-elgreco d9a4ce0
use fromstr
ion-elgreco e3c7189
add overwrite_schema support
ion-elgreco 5af1251
fix clippy of unrelated code ?
ion-elgreco 3744384
cargo fmt
ion-elgreco 2e1f0c9
resolve #1860
r3stl355 fee4d77
docs: on append, overwrite, delete and z-ordering (#1897)
MrPowers 3173ad7
docs: update python docs link in readme.md (#1899)
thomasfrederikhoeck fe4fe51
fix: use physical name for column name lookup in partitions (#1836)
aersam c38b518
ci: run doctest in CI for Python API examples (#1840)
marijncv 3ed7df0
feat(python): add pyarrow to delta compatible schema conversion in wr…
ion-elgreco 573e8fe
resolve merge
ion-elgreco bb5815a
fix bug from conflict
ion-elgreco 8c56194
Merge branch 'main' into fix/expose_writer_rust_to_python_v2
ion-elgreco 381df0d
remove commented code
ion-elgreco 3ab7687
expose predicate, handle error better, and add overloads
ion-elgreco e73eea3
fmt
ion-elgreco b4f9695
use ? instead of unwrap
ion-elgreco 50e7257
Merge branch 'main' into fix/expose_writer_rust_to_python_v2
ion-elgreco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,6 +172,7 @@ async fn excute_non_empty_expr( | |
None, | ||
writer_properties, | ||
false, | ||
false, | ||
) | ||
.await?; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1013,6 +1013,7 @@ async fn execute( | |
None, | ||
writer_properties, | ||
safe_cast, | ||
false, | ||
) | ||
.await?; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -363,6 +363,7 @@ async fn execute( | |
None, | ||
writer_properties, | ||
safe_cast, | ||
false, | ||
) | ||
.await?; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the schemas here have Eq or PartialEq on them? This might not be as straight forward as this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has PartialEq on them. This piece was also reused from src/lib.rs in the python module