fix(python): sort before schema comparison #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye and
roeap
as code owners
|
@ion-elgreco would it be possible for you to add at least one test to validate the behavior change addresses the issue in #1853 If you don't have the time, I'll pick this up tomorrow and merge it |
ion-elgreco
force-pushed
the
fix/use_schema_in_writer
branch
from
e9444b3 to
5a8bde6
Compare
|
@rtyler added a test now :) |
ion-elgreco
force-pushed
the
fix/use_schema_in_writer
branch
from
2d84094 to
3d016af
Compare
rtyler
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes this PR: #1854, @PierreDubrulle thanks for pointing it out
Related Issue(s)