fix(rust): special characters in s3 paths #2308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
alexr-bq
changed the title
rtyler
reviewed
Mar 22, 2024
| @@ -46,7 +46,18 @@ impl LogStoreFactory for S3LogStoreFactory { | |||
| location: &Url, | |||
| options: &StorageOptions, | |||
| ) -> DeltaResult<Arc<dyn LogStore>> { | |||
| let store = url_prefix_handler(store, Path::parse(location.path())?)?; | |||
| let path_decoded = match urlencoding::decode(location.path()) { | |||
There was a problem hiding this comment.
This line would benefit from a comment as to what this decoding does/why it exists
Co-authored-by: R. Tyler Croy <[email protected]>
rtyler
reviewed
Mar 28, 2024
|
Is it correct to use URL encoding here? I believe Delta Lake uses URI encoded paths everywhere and not URL encoded paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2266
We construct a "Prefix handler" for S3 paths. This prefix is passed into an s3 API that does not expect a URL-encoded path, so here we decode the path to support paths with characters such as spaces.
Related Issue(s)
2266