Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python, rust): use require files #2809

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Aug 21, 2024

Description

The description of the main changes of your pull request

Follow up PR

Use tombstones flag as well

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Aug 21, 2024
@ion-elgreco ion-elgreco force-pushed the fix/use_require_files branch from 89a4c5a to 7381060 Compare August 21, 2024 19:22
@ion-elgreco ion-elgreco changed the title fix: use require files fix(python, rust): use require files Aug 21, 2024
@ion-elgreco ion-elgreco self-assigned this Aug 22, 2024
@ion-elgreco ion-elgreco force-pushed the fix/use_require_files branch from 7381060 to ff8617f Compare August 24, 2024 11:11
@ion-elgreco ion-elgreco marked this pull request as ready for review September 7, 2024 11:42
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 24 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (507b50e) to head (116f785).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/src/lib.rs 0.00% 12 Missing ⚠️
crates/core/src/operations/constraints.rs 40.00% 3 Missing ⚠️
crates/core/src/kernel/snapshot/mod.rs 81.81% 1 Missing and 1 partial ⚠️
crates/core/src/operations/delete.rs 75.00% 1 Missing ⚠️
crates/core/src/operations/load.rs 66.66% 1 Missing ⚠️
crates/core/src/operations/merge/mod.rs 75.00% 1 Missing ⚠️
crates/core/src/operations/optimize.rs 66.66% 1 Missing ⚠️
crates/core/src/operations/update.rs 66.66% 1 Missing ⚠️
crates/core/src/operations/vacuum.rs 66.66% 1 Missing ⚠️
crates/core/src/operations/write.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   72.66%   72.62%   -0.04%     
==========================================
  Files         131      131              
  Lines       39962    40015      +53     
  Branches    39962    40015      +53     
==========================================
+ Hits        29038    29062      +24     
- Misses       9065     9088      +23     
- Partials     1859     1865       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not sure I understand this "feature" but that's no reason not to merge 😆

@rtyler rtyler enabled auto-merge September 9, 2024 14:11
@rtyler rtyler added this pull request to the merge queue Sep 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 9, 2024
@ion-elgreco
Copy link
Collaborator Author

@rtyler this essentially reintroduces the option to skip reading all add actions and keeping that in memory for append only workloads.

It also puts the necessary guard rails in place so people don't do operations where we need to know the add actions :p

@rtyler rtyler added this pull request to the merge queue Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 10, 2024
@rtyler rtyler enabled auto-merge September 10, 2024 19:09
@rtyler rtyler added this pull request to the merge queue Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 10, 2024
@rtyler rtyler added this pull request to the merge queue Sep 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 10, 2024
@rtyler rtyler enabled auto-merge September 12, 2024 13:45
@rtyler rtyler added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 12, 2024
@rtyler rtyler enabled auto-merge September 12, 2024 14:22
@rtyler rtyler added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 12, 2024
@rtyler rtyler force-pushed the fix/use_require_files branch from 8b531e7 to 116f785 Compare September 12, 2024 15:11
@rtyler rtyler merged commit ad35eda into delta-io:main Sep 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
2 participants