feat: improve AWS credential loading between S3 and DynamoDb code paths #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyler
added
binding/python
rtyler
force-pushed
the
bug/iam-assume-role
branch
from
b2bad8a to
1cd8d98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2887 +/- ##
==========================================
- Coverage 72.61% 72.42% -0.20%
==========================================
Files 131 131
Lines 40016 40011 -5
Branches 40016 40011 -5
==========================================
- Hits 29057 28976 -81
- Misses 9088 9166 +78
+ Partials 1871 1869 -2 ☔ View full report in Codecov by Sentry. |
|
Oh goodie, these tests fail in the GitHub Action runner environment and do not in local development. What a fun mystery this will be! 🕵️♂️ |
rtyler
force-pushed
the
bug/iam-assume-role
branch
from
a5a9704 to
86ad7c2
Compare
This change implements a number of improvements to the code paths for loading credentials. This is a prerequisite to fixing assume role support delta-io#2879 but should also address a number of bugs I noticed: * Python libraries can pass in keys via `storage_options` which are used for configuration of the AmazonS3 ObjectStore, but those credentials would not be used in the construction of the DynamoDB connection * Using AWS credentials such as those from ~/.aws/profile or SSO would not be properly dropped into the AmazonS3 object store creation There is some additional work that needs to come in to clean up how various options overrides are managed still. Sponsored-by: Scribd Inc.
the latest aws-config does a proper sequencing on the credential resolution and avoids unnecessary queries to IMDSv2
rtyler
force-pushed
the
bug/iam-assume-role
branch
from
86ad7c2 to
9e2d000
Compare
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
rtyler
added a commit
to delta-io/kafka-delta-ingest
that referenced
this pull request
Sep 17, 2024
…ssume role support See delta-io/delta-rs#2887
rtyler
added a commit
to rtyler/kafka-delta-ingest
that referenced
this pull request
Sep 17, 2024
…ssume role support See delta-io/delta-rs#2887
hntd187
reviewed
Sep 17, 2024
hntd187
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a number of improvements to the code paths for loading credentials. This is a prerequisite to fixing assume role support #2879 but should also address a number of bugs I noticed:
storage_optionswhich are used for configuration of the AmazonS3 ObjectStore, but those credentials would not be used in the construction of the DynamoDB connectionThere is some additional work that needs to come in to clean up how various options overrides are managed still.
Sponsored-by: Scribd Inc.