docs: updating docs for MinIO and Docker, with working conditional put support #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…references to dynamodb from cloudflare/minio page
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
@rwhaling any errors with conditional put? |
|
Yep @ion-elgreco, just commented in the issue, but getting |
|
@rwhaling can you share the logs. set the ENV var before importing deltalake: RUST_LOG=debug |
|
@ion-elgreco sure, thank you! With I get these logs: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
==========================================
- Coverage 72.48% 72.48% -0.01%
==========================================
Files 131 131
Lines 40410 40410
Branches 40410 40410
==========================================
- Hits 29292 29291 -1
Misses 9238 9238
- Partials 1880 1881 +1 ☔ View full report in Codecov by Sentry. |
Hmmm |
|
@rwhaling can you try: "AWS_CONDITIONAL_PUT" |
|
Yep. Same error: |
|
@rwhaling looking into it, give me a sec |
|
@ion-elgreco - following the instructions here: https://github.com/delta-io/delta-rs/blob/main/CONTRIBUTING.md But struggling with getting pyarrow built - Sorry, I feel like I'm just bumping into one yak-shave after another. Going to keep working on this - would like to invest the time and get a proper dev environment working over here. (Seems like this probably is related to the very old Mac OS version I am on) |
|
@rwhaling it's probably that because you usually don't have to build pyarrow yourself |
|
In the mean time you can use aws_conditional_put in lowercase and it should work |
|
Thanks so much @ion-elgreco! FWIW - I think I did manage to build pyarrow and then build the deltalake wheel, and I think I'm still getting the same error? But I don't totally trust my various hacks around the wheel installation yet, so don't want to pull you into yet another rabbit hole today - will hack on that a little more over the next few days - |
rwhaling
changed the title
|
@ion-elgreco @rtyler - will take another pass at this. Curious how fast y'all like to move with releases - if #2896 is going to go out soon, I might just hold on this and make the docs a little cleaner with Do y'all normally sync doc/site updates with releases, or do they go live at a faster clip? |
rtyler
previously approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
@rwhaling could you resolve the merge conflict? |
|
yep, on it |
|
@ion-elgreco @rtyler should be good to go? lmk if I bungled something, I'm still clunky working across forks. |
|
@rwhaling great, can you also squash the commits into one commit? Easiest would be to just do git push --force-with-lease |
|
@rtyler is too fast haha, thank y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few typos in cloudflare/minio docs page, adds working docker example and notes on special storage_option flags for http vs https.
Related Issue(s)
Notes
Updated docs to use
"aws_conditional_put":"etag"due to the issue identified below.