Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double-encode paths during zorder optimize when they contain special characters #2897

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Sep 22, 2024

The real fix should be likely done in Datafusion, allowing [ListingTableUrl] to be directly created rather than needing to parse the &str passed through

Fixes #2834

@rtyler rtyler added the binding/rust Issues for the Rust crate label Sep 22, 2024
@github-actions github-actions bot added the binding/python Issues for the Python package label Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 95.14563% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (98a64a1) to head (62d3f27).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/optimize.rs 95.14% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2897      +/-   ##
==========================================
+ Coverage   72.41%   72.50%   +0.09%     
==========================================
  Files         133      131       -2     
  Lines       40281    40362      +81     
  Branches    40281    40362      +81     
==========================================
+ Hits        29169    29266      +97     
+ Misses       9240     9219      -21     
- Partials     1872     1877       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ial characters

The real fix should be likely done in Datafusion, allowing
[ListingTableUrl] to be directly created rather than needing to parse
the &str passed through
@rtyler rtyler force-pushed the bug/zorder-space-2834 branch from 974e6a0 to 62d3f27 Compare September 22, 2024 18:33
@rtyler rtyler marked this pull request as ready for review September 22, 2024 19:32
@rtyler rtyler enabled auto-merge September 22, 2024 19:32
@rtyler rtyler added this pull request to the merge queue Sep 22, 2024
Merged via the queue into delta-io:main with commit 68f6d74 Sep 22, 2024
24 checks passed
@rtyler rtyler deleted the bug/zorder-space-2834 branch September 22, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z-order fails on table that is partitioned by value with space
2 participants