fix: ListingSchemaProvider not forwarding custom storage_options
#2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ListingTableProvider` used to gather `delta tables` from an `object_store` did not passed the `storage_options` (connection details) to the `object_store` library. Therefore, nothing was happening. This PR fixes that specific issue
Nordalf
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
Nordalf
changed the title
ListingTableProvider missing storage_optionsListingTableProvider missing storage_options (Azure)
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
Nordalf
changed the title
ListingTableProvider missing storage_options (Azure)ListingTableProvider missing storage_options
Nordalf
changed the title
ListingTableProvider missing storage_optionsListingTableProvider not passing storage_options
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
=======================================
Coverage 72.40% 72.41%
=======================================
Files 131 131
Lines 40496 40496
Branches 40496 40496
=======================================
+ Hits 29323 29325 +2
+ Misses 9292 9291 -1
+ Partials 1881 1880 -1 ☔ View full report in Codecov by Sentry. |
Nordalf
changed the title
ListingTableProvider not passing storage_optionsListingSchemaProvider not passing storage_options
Nordalf
changed the title
ListingSchemaProvider not passing storage_optionsListingSchemaProvider not forwarding custom storage_options
…et forwarded to ListingSchemaProvider correctly
rtyler
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ListingTableProviderused to gatherdelta tablesfrom anobject_storedid not pass thestorage_options(connection details) to theobject_storelibrary. Therefore, it was not possible to establish a connection. This PR fixes that specific issueRelated Issue(s)
None
Documentation
None