Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update createdTime during schema evolution #2926

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

The description of the main changes of your pull request

Related Issue(s)

@ion-elgreco ion-elgreco force-pushed the fix--keep-other-metadata branch from 5706bbb to 1f6cd6f Compare October 6, 2024 18:03
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (374d355) to head (32a3945).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/write.rs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2926      +/-   ##
==========================================
- Coverage   72.44%   72.41%   -0.03%     
==========================================
  Files         131      131              
  Lines       40496    40505       +9     
  Branches    40496    40505       +9     
==========================================
- Hits        29337    29333       -4     
  Misses       9291     9291              
- Partials     1868     1881      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco enabled auto-merge October 6, 2024 18:23
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this is the right fix for the "bug", technically the createdTime is an optional field but it should be from the time when the action itself is being created.

I will take this and rework it with a test

@ion-elgreco
Copy link
Collaborator Author

I do not believe this is the right fix for the "bug", technically the createdTime is an optional field but it should be from the time when the action itself is being created.

I will take this and rework it with a test

Ah I thought it was the time of table creation

@rtyler rtyler force-pushed the fix--keep-other-metadata branch from 77ae23f to 32a3945 Compare October 7, 2024 14:33
@rtyler rtyler changed the title fix: keep original metadata during schema evolution fix: update createdTime during schema evolution Oct 7, 2024
@ion-elgreco ion-elgreco added this pull request to the merge queue Oct 7, 2024
Merged via the queue into delta-io:main with commit f9436cb Oct 7, 2024
23 checks passed
@ion-elgreco ion-elgreco deleted the fix--keep-other-metadata branch October 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createdTime lost in metadata after schema change
2 participants