-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update createdTime during schema evolution #2926
fix: update createdTime during schema evolution #2926
Conversation
5706bbb
to
1f6cd6f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2926 +/- ##
==========================================
- Coverage 72.44% 72.41% -0.03%
==========================================
Files 131 131
Lines 40496 40505 +9
Branches 40496 40505 +9
==========================================
- Hits 29337 29333 -4
Misses 9291 9291
- Partials 1868 1881 +13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not believe this is the right fix for the "bug", technically the createdTime
is an optional field but it should be from the time when the action itself is being created.
I will take this and rework it with a test
Ah I thought it was the time of table creation |
77ae23f
to
32a3945
Compare
Description
The description of the main changes of your pull request
Related Issue(s)