fix: panics when creating delta tables in threads #2940
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading in delta tables from multiple threads is causing panics. Reproducible example:
causes
This race condition is caused by multiple threads trying to acquire and set the
PID
. Multiple threads could succeed at thePID.get()
call at time before any threads set thePID
, but only one thread can successfully callPID.set
, causing the remaining threads to panic.This fixes by using
get_or_init
for settingPID
, and only panics if the returnedruntime_pid
is different from the currentpid
.Related Issue(s)