Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed a bunch of warnings and deprecations #3020

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

hntd187
Copy link
Collaborator

@hntd187 hntd187 commented Nov 22, 2024

Description

I fixed some warnings, only one allow this time because it made sense to keep the invoke.

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Nov 22, 2024
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay thanks!

@rtyler rtyler added this to the v0.22 milestone Nov 22, 2024
@rtyler rtyler enabled auto-merge November 22, 2024 14:29
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (0c4344f) to head (2301c69).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/writer/stats.rs 84.61% 2 Missing ⚠️
crates/core/src/delta_datafusion/expr.rs 0.00% 1 Missing ⚠️
python/src/features.rs 0.00% 1 Missing ⚠️
python/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3020      +/-   ##
==========================================
+ Coverage   72.44%   72.46%   +0.02%     
==========================================
  Files         128      128              
  Lines       40841    40845       +4     
  Branches    40841    40845       +4     
==========================================
+ Hits        29587    29600      +13     
- Misses       9363     9367       +4     
+ Partials     1891     1878      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rtyler rtyler added this pull request to the merge queue Nov 22, 2024
Merged via the queue into delta-io:main with commit cb80931 Nov 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants