chore: refactor some of the writebuilder preconditions into the appropriate function #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
+ Coverage 72.65% 72.68% +0.03%
==========================================
Files 128 128
Lines 41199 41318 +119
Branches 41199 41318 +119
==========================================
+ Hits 29932 30033 +101
+ Misses 9350 9340 -10
- Partials 1917 1945 +28 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
…priate function This change also refactors the check_preconditions function itself to be a bit less redundant and even includes some unit tests! Holy smokes! Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
fix/writebuilder-memory-2968
branch
from
d1641f2 to
c85a390
Compare
ion-elgreco
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also refactors the check_preconditions function itself to be a bit less redundant and even includes some unit tests! Holy smokes!
I'm going to stand up a few pull requests as I work through this refactor incrementally
Related to work on #2968