Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): pass ending_timestamp correctly #3025

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

Ending_timestamp was passed to starting_timestamp instead of ending_timestamp

cc@hntd187

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (c623644) to head (5688aa2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
- Coverage   72.68%   72.68%   -0.01%     
==========================================
  Files         128      128              
  Lines       41318    41318              
  Branches    41318    41318              
==========================================
- Hits        30033    30031       -2     
- Misses       9340     9342       +2     
  Partials     1945     1945              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ion-elgreco ion-elgreco added this pull request to the merge queue Nov 24, 2024
Merged via the queue into delta-io:main with commit 0d533fc Nov 24, 2024
24 checks passed
@ion-elgreco ion-elgreco deleted the fix--load_cdf-timestamp branch November 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_cdf() not returning changes between starting_timestamp and ending_timestamp
2 participants