fix: workaround for Add actions being read slightly differently out of parquet files #3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
==========================================
- Coverage 72.72% 72.71% -0.01%
==========================================
Files 128 128
Lines 41318 41357 +39
Branches 41318 41357 +39
==========================================
+ Hits 30047 30074 +27
+ Misses 9340 9336 -4
- Partials 1931 1947 +16 ☔ View full report in Codecov by Sentry. |
Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
fix/checkpoint-failure-3030
branch
from
1c450c0 to
ede79c1
Compare
…f parquet files This workaround fixes #3030 but I'm not quite happy about how. I believe there is likely an upstream issue in arrow that I have not been able to reproduce where the nullable struct (deletionVector) which has non-nullable members (e.g. storageType) that are being read as empty strings rather than `null`. This issue started to appear with the v0.22 release which included an upgrade to datafusion 43 and arrow 53. I believe the latter is causing the issue here since it affects non-datafusion code paths. This workaround at least allows us to move forward and release a v0.22.1 while continuing to hunt down the issue. Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
fix/checkpoint-failure-3030
branch
from
ede79c1 to
53ccd68
Compare
rtyler
changed the title
rtyler
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
hntd187
as code owners
ion-elgreco
approved these changes
Nov 29, 2024
|
@rtyler did you file an issue in arrow-rs? |
|
@ion-elgreco my suspicions are that it lies upstream, but I don't have any confirmation |
|
This test should also check the final state of the table is correct. I expect it to not: #3030 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workaround fixes #3030 but I'm not quite happy about how. I believe there is likely an upstream issue in arrow that I have not been able to reproduce where the nullable struct (deletionVector) which has non-nullable members (e.g. storageType) that are being read as empty strings rather than
null.This issue started to appear with the v0.22 release which included an upgrade to datafusion 43 and arrow 53. I believe the latter is causing the issue here since it affects non-datafusion code paths.
This workaround at least allows us to move forward and release a v0.22.1 while continuing to hunt down the issue.