Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use uv #3042

Merged
merged 2 commits into from
Dec 15, 2024
Merged

chore: use uv #3042

merged 2 commits into from
Dec 15, 2024

Conversation

thomas-chauvet
Copy link
Contributor

Description

Add uv for python dependency management and building tool.

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Dec 2, 2024
python/CONTRIBUTING.md Outdated Show resolved Hide resolved
python/Makefile Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.68%. Comparing base (89f5f72) to head (4518b2f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
+ Coverage   72.64%   72.68%   +0.03%     
==========================================
  Files         129      129              
  Lines       41573    41573              
  Branches    41573    41573              
==========================================
+ Hits        30202    30218      +16     
+ Misses       9401     9397       -4     
+ Partials     1970     1958      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco
Copy link
Collaborator

Some parts of CI need to be updated to use UV as well: https://github.com/delta-io/delta-rs/blob/main/.github/workflows/python_build.yml

@ion-elgreco
Copy link
Collaborator

Changes look good, but can you resolve the cache dependency glob? Once CI passes we can merge it : )

@thomas-chauvet
Copy link
Contributor Author

Changes look good, but can you resolve the cache dependency glob? Once CI passes we can merge it : )

Should be ok, I needed to checkout the repo before in the setup action. Hope it's ok :)

@ion-elgreco
Copy link
Collaborator

@thomas-chauvet it's still failing, can you look at it

@thomas-chauvet
Copy link
Contributor Author

@ion-elgreco, sorry I missed that it did run
It should be ok with the right path now

@ion-elgreco
Copy link
Collaborator

@ion-elgreco, sorry I missed that it did run
It should be ok with the right path now

Just one more failure during install, you need to explicitly create a venv or install it system-wide :)

Signed-off-by: Thomas <[email protected]>

docs: fix activate venv

Signed-off-by: Thomas <[email protected]>

fix: pip uninstall with uv

Signed-off-by: Thomas <[email protected]>

chore: update CI workflows

Signed-off-by: Thomas <[email protected]>

fix(ci): need to checkout to use uv.lock

Signed-off-by: Thomas <[email protected]>

fix(ci): fix uv.lock path

Signed-off-by: Thomas <[email protected]>

Update .github/workflows/python_build.yml

Update .github/workflows/python_build.yml
ion-elgreco
ion-elgreco previously approved these changes Dec 15, 2024
ion-elgreco
ion-elgreco previously approved these changes Dec 15, 2024
@ion-elgreco ion-elgreco disabled auto-merge December 15, 2024 15:45
@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2024
@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 15, 2024
Merged via the queue into delta-io:main with commit dc1c556 Dec 15, 2024
24 checks passed
@thomas-chauvet
Copy link
Contributor Author

Thanks for the PR, didn't have time to check on it last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use UV and Justfiles
2 participants