-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attempt to workaround problems reading actions as empty rather than null #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
Issues for the Python package
binding/rust
Issues for the Rust crate
labels
Dec 3, 2024
rtyler
changed the title
chore: add more robust regression tests for the checkpoint related failure(s)
fix: attempt to workaround problems reading actions as empty rather than null
Dec 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
==========================================
- Coverage 72.68% 72.62% -0.06%
==========================================
Files 129 129
Lines 41462 41509 +47
Branches 41462 41509 +47
==========================================
+ Hits 30137 30147 +10
- Misses 9376 9415 +39
+ Partials 1949 1947 -2 ☔ View full report in Codecov by Sentry. |
rtyler
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
hntd187
as code owners
December 4, 2024 16:47
rtyler
force-pushed
the
fix/checkpoint-3030
branch
2 times, most recently
from
December 4, 2024 20:13
54487ea
to
09f1376
Compare
…ilure(s) See delta-io#3030 Signed-off-by: R. Tyler Croy <[email protected]>
The root cause remains elusive but with the recent arrow upgrade the nullable deletionVector struct, which contains non-nullable fields, is being read out as "empty" in the default case rather than as null. This causes the "seen" code in log replay to fail to correctly identify files which should be marked as removed when computing the state of the snapshot. This change introduces another workaround that I am still not thrilled about 😒 Fixes delta-io#3030 Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
fix/checkpoint-3030
branch
from
December 4, 2024 20:15
09f1376
to
48ba19f
Compare
ion-elgreco
approved these changes
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3030