Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add explicit type casts while merge #3050

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

t1g0rz
Copy link
Contributor

@t1g0rz t1g0rz commented Dec 10, 2024

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Dec 10, 2024
Signed-off-by: Igor Vitenko <[email protected]>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.66%. Comparing base (2501f2f) to head (8b5f421).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/merge/mod.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
- Coverage   72.67%   72.66%   -0.01%     
==========================================
  Files         129      129              
  Lines       41625    41626       +1     
  Branches    41625    41626       +1     
==========================================
- Hits        30251    30248       -3     
- Misses       9414     9417       +3     
- Partials     1960     1961       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco
Copy link
Collaborator

Thanks! @t1g0rz

Exactly what I had in mind

@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 10, 2024
Merged via the queue into delta-io:main with commit e665ca8 Dec 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent schema handling for int64 columns in Delta Table updated with pandas object type
2 participants