Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise during checkpoint creating with without_files #3059

Merged

Conversation

ion-elgreco
Copy link
Collaborator

@ion-elgreco ion-elgreco commented Dec 15, 2024

Description

  • If explicitly creating checkpoint, we raise
  • If checkpoint creation called in post_commit_hook, we warn

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.64%. Comparing base (dc1c556) to head (b68bf6f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/protocol/checkpoints.rs 50.00% 3 Missing ⚠️
crates/core/src/operations/transaction/mod.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
- Coverage   72.68%   72.64%   -0.04%     
==========================================
  Files         129      129              
  Lines       41573    41584      +11     
  Branches    41573    41584      +11     
==========================================
- Hits        30216    30208       -8     
- Misses       9397     9406       +9     
- Partials     1960     1970      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is silly

@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2024
@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 15, 2024
Merged via the queue into delta-io:main with commit a51d75a Dec 15, 2024
24 checks passed
@ion-elgreco ion-elgreco deleted the fix/checkpoint_without_files_corruption branch December 15, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write operations with without_files lead to data loss due to checkpointing
2 participants