chore: bump versions for next release(s) #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
rtyler
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
hntd187
as code owners
Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
you-minor-im-major
branch
from
25f0314 to
9b86df0
Compare
|
I am fine with removing it, but we should remove the checkout of the lockfile in the CI now, so that it can pass |
rtyler
force-pushed
the
you-minor-im-major
branch
from
9b86df0 to
cab44f2
Compare
From the [documentation](https://docs.astral.sh/uv/concepts/projects/layout/#the-lockfile) > Unlike the pyproject.toml, which is used to specify the broad requirements of your project, the lockfile contains the exact resolved versions that are installed in the project environment. This file should be checked into version control, allowing for consistent and reproducible installations across machines. > > A lockfile ensures that developers working on the project are using a consistent set of package versions. Additionally, it ensures when deploying the project as an application that the exact set of used package versions is known. The problem with the presence of this `uv.lock` for purposes of development of a library like `deltalake` is that `pip` installations of the released package will _not_ have the contents of that `uv.lock` file. Therefore I want it to be removed so that our local installations, and CI, are always using `pyproject.toml` to resolve their dependencies in a manner which is consistent with the users of the installed package. Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
you-minor-im-major
branch
from
cab44f2 to
951f814
Compare
Fixes delta-io#3065 Signed-off-by: R. Tyler Croy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
- Coverage 72.65% 72.42% -0.23%
==========================================
Files 129 128 -1
Lines 41584 41314 -270
Branches 41584 41314 -270
==========================================
- Hits 30211 29921 -290
- Misses 9405 9425 +20
Partials 1968 1968 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also removes
uv.lock. From the documentationThe problem with the presence of this
uv.lockfor purposes of development of a library likedeltalakeis thatpipinstallations of the released package will not have the contents of thatuv.lockfile.Therefore I want it to be removed so that our local installations, and CI, are always using
pyproject.tomlto resolve their dependencies in a manner which is consistent with the users of the installed package.