Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add decimal expr parsing #3090

Merged
merged 1 commit into from
Jan 1, 2025
Merged

fix: add decimal expr parsing #3090

merged 1 commit into from
Jan 1, 2025

Conversation

ion-elgreco
Copy link
Collaborator

@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Dec 29, 2024
roeap
roeap approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@roeap roeap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

not sure where the test failures are coming from though.

@rtyler rtyler added this to the v0.23 milestone Dec 31, 2024
@rtyler
Copy link
Member

rtyler commented Jan 1, 2025

@ion-elgreco will you sign off on your commits and re-push? Then this will merge automatically

@ion-elgreco ion-elgreco force-pushed the fix--decimal-parsing branch from 8bda53c to 12ae18d Compare January 1, 2025 09:51
@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (64c1b1a) to head (12ae18d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/expr.rs 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3090      +/-   ##
==========================================
- Coverage   72.52%   72.51%   -0.02%     
==========================================
  Files         128      128              
  Lines       41182    41197      +15     
  Branches    41182    41197      +15     
==========================================
+ Hits        29869    29874       +5     
- Misses       9409     9410       +1     
- Partials     1904     1913       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Jan 1, 2025
Merged via the queue into delta-io:main with commit b426b9e Jan 1, 2025
24 checks passed
@ion-elgreco ion-elgreco deleted the fix--decimal-parsing branch January 1, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeap roeap roeap approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

@hntd187 hntd187 Awaiting requested review from hntd187 hntd187 is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Milestone
v0.23
Development

Successfully merging this pull request may close these issues.

Cannot merge when predicate contains Decimal comparision
3 participants
@ion-elgreco @rtyler @roeap