-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make put-if-absent default for S3 stores #3091
Conversation
681c7b8
to
d7d0eab
Compare
This is a good change overall and I don't think it should be a probably to slyly slip this in as a default when the AWS_LOCKING_PROVIDER environment variable is not set. In my setups for example I require the S3DynamoDbLogStore for concurrent coordination with Spark writers, so I will want to do a little more testing with this to make sure that the right log store is chosen in the right circumstances |
1849be3
to
0c833d6
Compare
Signed-off-by: R. Tyler Croy <[email protected]>
The options handling must occur before the ObjectStore is actually created in order for the object_store crate to properly inherit the conditional_put configuration setting. Otherwise an OSError is returned (object_store NotImplemented error) Signed-off-by: R. Tyler Croy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
+ Coverage 72.30% 72.52% +0.21%
==========================================
Files 128 128
Lines 41173 41182 +9
Branches 41173 41182 +9
==========================================
+ Hits 29770 29867 +97
+ Misses 9498 9406 -92
- Partials 1905 1909 +4 ☔ View full report in Codecov by Sentry. |
0c833d6
to
9323c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed and updated this one 👍
Description