chore: pin path tree #3092
chore: pin path tree #3092
Conversation
ion-elgreco
force-pushed
the
chore/pin_path_tree
branch
4 times, most recently
from
7e2d3a9 to
1ec248b
Compare
ion-elgreco
force-pushed
the
chore/pin_path_tree
branch
from
1ec248b to
15a0eb3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3092 +/- ##
==========================================
- Coverage 72.30% 72.29% -0.01%
==========================================
Files 128 128
Lines 41173 41173
Branches 41173 41173
==========================================
- Hits 29770 29767 -3
Misses 9498 9498
- Partials 1905 1908 +3 ☔ View full report in Codecov by Sentry. |
| @@ -75,3 +75,6 @@ async-trait = { version = "0.1" } | |||
| futures = { version = "0.3" } | |||
| tokio = { version = "1" } | |||
| num_cpus = { version = "1" } | |||
|
|
|||
| [patch.crates-io] | |||
| path-tree = { git = "https://github.com/viz-rs/path-tree.git", rev = "03f85c289cea8a3ae9ee7bcadba5633fb465b8da"} # pin to 0.8.1 due to nightly features | |||
There was a problem hiding this comment.
Is this a dev only dependency? We cannot release with non-crates.io released packages in the manifests
There was a problem hiding this comment.
I have no clue, I couldn't see it in the dependency tree. Might only appear during tests
There was a problem hiding this comment.
@fundon that may be correct however I have been quite resistant to such rapid MSRV version upgrades for us in the past. For example we just had to bump to 1.81, and there's some rumblings about perhaps 1.82 which was only released about 2.5 months ago. An MSRV upgrade does not come with zero cost for our own build infrastructure nor for our users, so I try to make sure we're upgrading for "pretty good reasons".
In this case, i actually haven't seen the failure that @ion-elgreco was seeing when he looked at this. 🙈
There was a problem hiding this comment.
Or lock version: =0.8.1, see https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility
There was a problem hiding this comment.
Or lock version:
=0.8.1, see https://doc.rust-lang.org/cargo/reference/resolver.html#semver-compatibility
I did that actually but it still pulled in 0.8.2
There was a problem hiding this comment.
Sorry, I caused you some trouble. 0.8.2 has been yanked. No changes required.
There was a problem hiding this comment.
Hah, I just saw the failure in a GitHub action, and also just noticed that @fundon you are the author of path-tree, and I also noticed that 0.8.2 is yanked 😆
@fundon I'm happy to help test out changes on older rusts if you want to give 0.8.3 a try, I can be found at rtyler on the delta-users slack or as rtyler on IRC (libera.chat)
There was a problem hiding this comment.
Sorry, I caused you some trouble.
0.8.2has been yanked. No changes required.
No worries! Thanks for your help!
Description
Should resolve the build failures we see atm @roeap