chore: use builder API to create FileScanConfig
#3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
alamb
commented
Feb 25, 2025
| output_ordering: vec![], | ||
| }) | ||
| let mut exec_plan_builder = ParquetExecBuilder::new( | ||
| FileScanConfig::new(self.log_store.object_store_url(), file_schema) |
There was a problem hiding this comment.
The idea is to use FileScanConfig::new()` rather than explicitly create the structure manually.
new() fills in the defaults
alamb
force-pushed
the
alamb/update_filescan_config
branch
from
0da8007 to
c058b5b
Compare
alamb
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
alamb
force-pushed
the
alamb/update_filescan_config
branch
from
c058b5b to
4b0cfc1
Compare
alamb
changed the title
FileScanConfigFileScanConfig
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
==========================================
- Coverage 72.14% 72.11% -0.03%
==========================================
Files 143 143
Lines 45724 45701 -23
Branches 45724 45701 -23
==========================================
- Hits 32986 32959 -27
+ Misses 10666 10665 -1
- Partials 2072 2077 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrew Lamb <[email protected]>
ion-elgreco
force-pushed
the
alamb/update_filescan_config
branch
from
4b0cfc1 to
3694c23
Compare
ion-elgreco
approved these changes
Feb 25, 2025
ion-elgreco
approved these changes
Feb 25, 2025
|
Thanks @ion-elgreco for the fast reviews 🚤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note this PR should have no functional change
Similarly to #3265, this is part of the DataFusion 46 upgrade in #3262, which I am trying to split into multiple parts to reduce the size of the diff (so to make it easier to review and debug)
Specifically, ParquetExec builder is non trivially changed as part of the upgrade, and new fields are added to
FileScanConfig. This this change updates the API to use the builder style API for FileScanConfig which makes the delta code less verbose as well as making the upgrade easierRelated Issue(s)
46.0.0apache/datafusion#14123Documentation