Skip to content

Commit

Permalink
Update for merge
Browse files Browse the repository at this point in the history
  • Loading branch information
allisonport-db committed Jan 8, 2025
1 parent c424af8 commit fcc0379
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ private SnapshotReportImpl(
public String getTablePath() {
return tablePath;
}

@Override
public UUID getReportUUID() {
return reportUUID;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ class MetricsReportSerializerSuite extends AnyFunSuite {

private def testSnapshotReport(snapshotReport: SnapshotReport): Unit = {
val timestampToVersionResolutionDuration = optionToString(
snapshotReport.getSnapshotMetrics().getTimestampToVersionResolutionDuration())
snapshotReport.getSnapshotMetrics().getTimestampToVersionResolutionDurationNs())
val loadProtocolAndMetadataDuration =
snapshotReport.getSnapshotMetrics().getLoadInitialDeltaActionsDuration()
snapshotReport.getSnapshotMetrics().getLoadInitialDeltaActionsDurationNs()
val exception: Optional[String] = snapshotReport.getException().map(_.toString)
val expectedJson =
s"""
Expand All @@ -49,8 +49,8 @@ class MetricsReportSerializerSuite extends AnyFunSuite {
|"version":${optionToString(snapshotReport.getVersion())},
|"providedTimestamp":${optionToString(snapshotReport.getProvidedTimestamp())},
|"snapshotMetrics":{
|"timestampToVersionResolutionDuration":${timestampToVersionResolutionDuration},
|"loadInitialDeltaActionsDuration":${loadProtocolAndMetadataDuration}
|"timestampToVersionResolutionDurationNs":${timestampToVersionResolutionDuration},
|"loadInitialDeltaActionsDurationNs":${loadProtocolAndMetadataDuration}
|}
|}
|""".stripMargin.replaceAll("\n", "")
Expand All @@ -59,8 +59,8 @@ class MetricsReportSerializerSuite extends AnyFunSuite {

test("SnapshotReport serializer") {
val snapshotContext1 = SnapshotQueryContext.forTimestampSnapshot("/table/path", 0)
snapshotContext1.getSnapshotMetrics.timestampToVersionResolutionDuration.record(10)
snapshotContext1.getSnapshotMetrics.loadInitialDeltaActionsDuration.record(1000)
snapshotContext1.getSnapshotMetrics.timestampToVersionResolutionTimer.record(10)
snapshotContext1.getSnapshotMetrics.loadInitialDeltaActionsTimer.record(1000)
snapshotContext1.setVersion(1)
val exception = new RuntimeException("something something failed")

Expand All @@ -79,8 +79,8 @@ class MetricsReportSerializerSuite extends AnyFunSuite {
|"version":1,
|"providedTimestamp":0,
|"snapshotMetrics":{
|"timestampToVersionResolutionDuration":10,
|"loadInitialDeltaActionsDuration":1000
|"timestampToVersionResolutionDurationNs":10,
|"loadInitialDeltaActionsDurationNs":1000
|}
|}
|""".stripMargin.replaceAll("\n", "")
Expand Down

0 comments on commit fcc0379

Please sign in to comment.