[Spark] Propagate catalog table through DeltaSink #2109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
reviewed
Sep 27, 2023
spark/src/test/scala/org/apache/spark/sql/delta/DeltaSuite.scala
Outdated
Show resolved
Hide resolved
tdas
reviewed
Sep 27, 2023
spark/src/test/scala/org/apache/spark/sql/delta/DeltaSuite.scala
Outdated
Show resolved
Hide resolved
revert unwanted changes
scottsand-db
approved these changes
Sep 28, 2023
tdas
approved these changes
Sep 28, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
In order to implement #2052 for streaming writes,
DeltaSinkneeds to track the catalog table, if any, so it can properly initialize the transactions it executes. We can't change the Spark DataSource API that creates the sink, so instead we add logic inDeltaAnalysisthat extracts the catalog table from theWriteToStreamand applies it to the underlyingDeltaSink.How was this patch tested?
New unit test.
Does this PR introduce any user-facing changes?
No.