[Spark] Fix resource leaking when a deletion vector file is not found #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
commented
Sep 27, 2023
| iterToReturn.asInstanceOf[Iterator[InternalRow]] | ||
| } catch { | ||
| case NonFatal(e) => | ||
| // Close the iterator if it is a closeable resource. The `ParquetFileFormat` opens |
There was a problem hiding this comment.
This pattern is similar to how Spark closes the iterator returned from the data sources.
ryan-johnson-databricks
approved these changes
Sep 27, 2023
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
The `DeltaParquetFileFormat` adds additional glue for filtering the deleting rows (according to the deletion vector) from the iterator returned by the `ParquetFileFormat`. In case when the DV file is not found, the iterator returned from `ParquetFileFormat` should be close. An integration test simulating the DV file deletion and verifying no resource leak. Closes delta-io#2113 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: d378b495630da31ff2af062dd9124874fdb69e12
vkorukanti
added a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
The `DeltaParquetFileFormat` adds additional glue for filtering the deleting rows (according to the deletion vector) from the iterator returned by the `ParquetFileFormat`. In case when the DV file is not found, the iterator returned from `ParquetFileFormat` should be close. An integration test simulating the DV file deletion and verifying no resource leak. Closes delta-io#2113 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: d378b495630da31ff2af062dd9124874fdb69e12
Kimahriman
pushed a commit
to Kimahriman/delta
that referenced
this pull request
Oct 3, 2023
The `DeltaParquetFileFormat` adds additional glue for filtering the deleting rows (according to the deletion vector) from the iterator returned by the `ParquetFileFormat`. In case when the DV file is not found, the iterator returned from `ParquetFileFormat` should be close. An integration test simulating the DV file deletion and verifying no resource leak. Closes delta-io#2113 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: d378b495630da31ff2af062dd9124874fdb69e12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The
DeltaParquetFileFormatadds additional glue for filtering the deleting rows (according to the deletion vector) from the iterator returned by theParquetFileFormat. In case when the DV file is not found, the iterator returned fromParquetFileFormatshould be close.How was this patch tested?
An integration simulating the DV file deletion and verifying no resource leak.
Does this PR introduce any user-facing changes?
No