[Spark] UniForm supports using Hive Metastore #2120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniForm HMS Migration by Hao Jiang <[email protected]>
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
UniForm will use HMS as catalog instead of using file system. Closes delta-io#2120 GitOrigin-RevId: f2d863c6e91e4d5d8c2e0f373f4c0c4ad9956fb6
vkorukanti
pushed a commit
to vkorukanti/delta
that referenced
this pull request
Oct 3, 2023
UniForm will use HMS as catalog instead of using file system. Closes delta-io#2120 GitOrigin-RevId: f2d863c6e91e4d5d8c2e0f373f4c0c4ad9956fb6
Kimahriman
pushed a commit
to Kimahriman/delta
that referenced
this pull request
Oct 3, 2023
UniForm will use HMS as catalog instead of using file system. Closes delta-io#2120 GitOrigin-RevId: f2d863c6e91e4d5d8c2e0f373f4c0c4ad9956fb6
singhpk234
reviewed
Oct 10, 2023
| @VisibleForTesting | ||
| void persistTable(Table hmsTable, boolean updateHiveTable) | ||
| throws TException, InterruptedException { | ||
| + hmsTable.getSd().setCols(Collections.singletonList(new FieldSchema("col", "array<string>", ""))); |
There was a problem hiding this comment.
why is this required, can't we just store empty cols ?
Comment on lines
+23
to
+25
| + StorageDescriptor newsd = storageDescriptor(metadata, hiveEngineEnabled); | ||
| + newsd.getSerdeInfo().setParameters(tbl.getSd().getSerdeInfo().getParameters()); | ||
| + tbl.setSd(newsd); // set to pickup any schema changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UniForm will migrate to use HMS to store Iceberg table data by Hao Jiang [email protected]
Which Delta project/connector is this regarding?
Description
Allow UniForm to use Hive metastore when converting to iceberg tables
How was this patch tested?
Update existing test cases
Does this PR introduce any user-facing changes?
No