[Spark] Minor update to generate_iceberg_jars.py to be specific about exclude files
#2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
approved these changes
Sep 29, 2023
Kimahriman
pushed a commit
to Kimahriman/delta
that referenced
this pull request
Oct 3, 2023
…ut exclude files The script `generate_iceberg_jars.py` breaks the build if the delta source is cloned in a directory with the name `source` or `opensource`. Update the script to be specific about the files to exclude (it should be `sources.jar`). Ran `build/sbt clean publishM2` successfully after deleting the `icebergShaded/libs` folder and was able to see the generated libs. Closes delta-io#2121 Signed-off-by: Venki Korukanti <[email protected]> GitOrigin-RevId: dbc0f87b3054c06c57eec699dba9349151260de1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
The script
generate_iceberg_jars.pybreaks the build if the delta source is cloned in a directory with the namesourceoropensource. Update the script to be specific about the files to exclude (it should besources.jar).How was this patch tested?
Ran
build/sbt clean publishM2successfully after deleting theicebergShaded/libsfolder and was able to see the generated libs.